-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOSurface] Updates for Xcode13 Beta 1 #12096
[IOSurface] Updates for Xcode13 Beta 1 #12096
Conversation
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1098.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add the two new fields and P/Invokes to the common ignore file, there are a lot of other API that we haven't bound in this framework, and which we'll probably have to bind first for any of these to make sense.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
Unrelated Test Failure: https://github.com/xamarin/maccore/issues/2443 |
I don't feel too confident with this one.
I added the missing p-invokes to the ignore since they are ignored in other platforms.
I added the two fields. They say they are supported in older versions and the iOS 11.4 intro test did not complain about them, but a good amount of other IOSurface* fields are in the common ignore and I am not sure why.