Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOSurface] Updates for Xcode13 Beta 1 #12096

Merged
merged 2 commits into from
Jul 13, 2021

Conversation

tj-devel709
Copy link
Contributor

I don't feel too confident with this one.
I added the missing p-invokes to the ignore since they are ignored in other platforms.

I added the two fields. They say they are supported in older versions and the iOS 11.4 intro test did not complain about them, but a good amount of other IOSurface* fields are in the common ignore and I am not sure why.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 9, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 9, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1098.BigSur'
Merge cfcb958 into 797a2f5

src/iosurface.cs Outdated Show resolved Hide resolved
src/iosurface.cs Outdated Show resolved Hide resolved
Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the two new fields and P/Invokes to the common ignore file, there are a lot of other API that we haven't bound in this framework, and which we'll probably have to bind first for any of these to make sense.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 84 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2625 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 135)

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 3648b2e into 26a8abe

@tj-devel709
Copy link
Contributor Author

Unrelated Test Failure: https://github.com/xamarin/maccore/issues/2443

@tj-devel709 tj-devel709 merged commit a202354 into xamarin:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants